Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move net_plugin vote message logging to different logger #14

Closed
heifner opened this issue Jan 23, 2024 · 0 comments · Fixed by #28
Closed

Move net_plugin vote message logging to different logger #14

heifner opened this issue Jan 23, 2024 · 0 comments · Fixed by #28
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Producti...

Comments

@heifner
Copy link
Member

heifner commented Jan 23, 2024 •
edited by arhag
Loading

Depends on #3.

net_plugin_impl logger currently logs all vote messages sent/received. This is a huge amount of logs. Move these logs onto a different logger that can be enabled separately than net_plugin_impl. Maybe net_plugin_if.
@arhag arhag added 👍 lgtm and removed triage labels Jan 29, 2024
@arhag arhag mentioned this issue Jan 29, 2024
Closed
@arhag arhag transferred this issue from AntelopeIO/leap Apr 10, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Apr 10, 2024
@arhag arhag changed the title IF: Move net_plugin vote message logging to different logger Move net_plugin vote message logging to different logger Apr 10, 2024
@heifner heifner self-assigned this Apr 12, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Apr 12, 2024
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Avoid one mutex lock and std::string construction on every log …
51728b5 
…call. Remove unused ulog.
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Add connection id to vote log output
b9a4ea6
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Remove unneeded includes
8deae48
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Add noexcept
9249e47
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Replaced hotstuff logger with vote logger. Moved existing vote …
8f8526b 
…related logging to vote_logger.
@heifner heifner mentioned this issue Apr 15, 2024
Merged
@heifner heifner linked a pull request Apr 15, 2024 that will close this issue
IF: Add logger for vote related logging #28
Merged
@heifner heifner moved this from Todo to In Progress in Team Backlog Apr 15, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Apr 15, 2024
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Log connection id
c8975e6
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Add deep-mind ACCEPTED_BLOCK_V2
034d0b7
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-14 Add comment that connection_id only for logging
3e6d836
heifner added a commit that referenced this issue Apr 19, 2024
@heifner
Merge remote-tracking branch 'spring/savanna' into GH-14-vote-loggin
2781b0f
heifner added a commit that referenced this issue Apr 19, 2024
@heifner
GH-14 Fix merge issue
6eb9d32
heifner added a commit that referenced this issue Apr 19, 2024
@heifner
Merge pull request #28 from AntelopeIO/GH-14-vote-loggin
395724e 
IF: Add logger for vote related logging
@heifner heifner closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

IF: Add logger for vote related logging AntelopeIO/spring
3 participants
@heifner @arhag @enf-ci-bot