Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: client connections incorrect #1006

Closed
heifner opened this issue Nov 1, 2024 · 0 comments · Fixed by #1032 or #1037
Closed

P2P: client connections incorrect #1006

heifner opened this issue Nov 1, 2024 · 0 comments · Fixed by #1032 or #1037
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.4

Comments

@heifner
Copy link
Member

heifner commented Nov 1, 2024

p2p client connections: 0/25, peer connections: 2/2, block producer peers: 0 shows connected to 2 of the configured 2 peers when the node is actually only connected to one of them. Looks like a regression from Leap 4.0 to Leap 5.0. In Leap 4.0 only connected peers are included in the first 2 of peer connections: 2/2. In Leap 5.0 this also includes peers that are not currently connected.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 1, 2024
@bhazzard bhazzard removed the triage label Nov 7, 2024
@bhazzard bhazzard added this to the Spring v1.0.4 milestone Nov 7, 2024
@bhazzard bhazzard added bug The product is not working as was intended. 👍 lgtm labels Nov 7, 2024
@heifner heifner self-assigned this Nov 14, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Nov 14, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Nov 14, 2024
heifner added a commit that referenced this issue Nov 14, 2024
@heifner
GH-1006 Do not include peers that are not currently connected in peer…
4acd24b 
… count
@heifner heifner mentioned this issue Nov 14, 2024
Merged
@heifner heifner linked a pull request Nov 14, 2024 that will close this issue
[1.0.4] P2P: Fix peer connections log output #1032
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Nov 15, 2024
heifner added a commit that referenced this issue Nov 18, 2024
@heifner
Merge pull request #1032 from AntelopeIO/GH-1006-p2p-client-count-1.0
4e0a498 
[1.0.4] P2P: Fix peer connections log output
heifner added a commit that referenced this issue Nov 18, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-1006-p2p-cl…
9c3fb8d 
…ient-count-main
@heifner heifner mentioned this issue Nov 18, 2024
Merged
heifner added a commit that referenced this issue Nov 18, 2024
@heifner
Merge pull request #1037 from AntelopeIO/GH-1006-p2p-client-count-main
60fc43d 
[1.0.4 -> main] P2P: Fix peer connections log output
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.0.4
3 participants
@bhazzard @heifner @enf-ci-bot