Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split system_tests into multiple suites such that each of them can finish CICD testing in time #100

Closed
wants to merge 1 commit into from

Conversation

linh2931
Copy link
Member

Resolved #99.

Fixed test failure in Spring AntelopeIO/spring#254

Change Description

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@linh2931 linh2931 requested review from heifner and spoonincode June 10, 2024 14:35
@spoonincode
Copy link
Member

What caused the ballooning of system_tests execution time? It's nearly 7x from what it was before switching to the new testers in #95. I'm not surprised to see something like 2x but 7x is a bit surprising considering it doesn't look like we added any new tests or such in #95.

@linh2931
Copy link
Member Author

What caused the ballooning of system_tests execution time? It's nearly 7x from what it was before switching to the new testers in #95. I'm not surprised to see something like 2x but 7x is a bit surprising considering it doesn't look like we added any new tests or such in #95.

I am digging it deeper on the cause. Thanks.

@linh2931
Copy link
Member Author

linh2931 commented Jun 10, 2024

Initial numbers when running eosio_system_tests with time command on my Ubuntu22 box:

  • Legacy tester: 6m32.055s
  • Savanna tester with 4 local BLS keys (current configuration): 18m19.707s
  • Savanna tester with 1 local BLS key: 13m31.346s

Looking into why even 1 key doubles the test time.

@linh2931
Copy link
Member Author

Configuring only one local finalizer helps to reduce system_tests to run in 7 minutes in CICD AntelopeIO/spring#266.

Close this PR for now.

@linh2931 linh2931 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split system_tests suite
2 participants