Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: unifying set_finalizers interface with Leap and BIOS Contract #34

Closed
linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #35
Closed

IF: unifying set_finalizers interface with Leap and BIOS Contract #34

linh2931 opened this issue Dec 15, 2023 · 0 comments · Fixed by #35
Labels
👍 lgtm

Comments

@linh2931
Copy link
Member

Currently CDT and Leap use abi_finalizer_policy while BIOS contract uses finalizer_policy. Some field names and types are also different. Unify them to reduce future confusion.

Error messages in BIOS contract in Leap libtester are not consistent with BIOS contract in Reference-Contracts. Should be kept consistent.

CDT AntelopeIO/cdt#257
Leap AntelopeIO/leap#1992
This was referenced Dec 15, 2023
Closed
Closed
Merged
@arhag arhag mentioned this issue Dec 15, 2023
Open
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
GH-34 Update set_finalizer errors
afe749a
@heifner heifner mentioned this issue Dec 19, 2023
Merged
3 tasks
@heifner heifner linked a pull request Dec 19, 2023 that will close this issue
Update set_finalizer errors #35
Merged
3 tasks
heifner added a commit that referenced this issue Dec 19, 2023
@heifner
Merge pull request #35 from AntelopeIO/GH-34-set-finalizer-errors
247b5c4 
Update set_finalizer errors
@heifner heifner closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👍 lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update set_finalizer errors AntelopeIO/reference-contracts
3 participants
@heifner @arhag @linh2931