-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Unification: Changes in controller to complete unification - Part 2 #2077
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e2804da
Update `start_block` for IF.
greg7mdp 610af7d
Mostly whitespace cleanup.
greg7mdp 7d933af
Change `[greg todo]` to `#warning` for `producer_authority_schedule` …
greg7mdp 1a3ded1
Resolve multiple `todo`s in controller and implement bew bhs::next() …
greg7mdp d2af863
GH-1980 Implement proposer policy change
heifner 57ccf14
Update some todo comments.
greg7mdp be875ee
Merge branch 'hotstuff_integration' of github.com:AntelopeIO/leap int…
greg7mdp 2c98018
Merge remote-tracking branch 'origin/gh_2034_part2' into GH-1980-prop…
heifner e896105
GH-1980 Fix merge issue
heifner a3c7628
Merge pull request #2078 from AntelopeIO/GH-1980-proposer
heifner 0e72f5a
Move `header_exts` to block_header_state
greg7mdp 53faa5b
Merge branch 'gh_2034_part2' of github.com:AntelopeIO/leap into gh_20…
greg7mdp 8e3dca2
GH-1980 Copy over active policies
heifner cd3190d
cleanup `next(block_header_state_input& data)` function and update `h…
greg7mdp ab52975
Merge branch 'gh_2034_part2' of github.com:AntelopeIO/leap into gh_20…
greg7mdp d01debb
Cleanup `next(const signed_block_header& h, ...)`.
greg7mdp 9499630
Add missing block id computation to `next()` function.
greg7mdp 7253499
Simplify `block_header_state_core::next()` API.
greg7mdp fa2a60a
Remove unneeded template parameter for `block_data_gen_t`
greg7mdp 1cc9fe3
Fix issue I introduced in commit 7253499
greg7mdp 6473f31
Update `apply_block()` so that it works for the IF path.
greg7mdp 854e9db
Fix todo for `report_block_header_diff`.
greg7mdp 71cf33c
remove `block_state::cached_id` and update `id()` member function.
greg7mdp 8934a42
Add `completed_block` construction for IF mode.
greg7mdp 161d585
Remove unneeded include.
greg7mdp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not
const &
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passing by reference (indirection with a pointer) would actually be slower since the whole struct is 8 bytes.