IF: implement block_header_state_core and its state transition #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Nov 21, 2023
heifner
approved these changes
Nov 21, 2023
greg7mdp
approved these changes
Nov 21, 2023
Comment on lines
26
to
28
| block_header_state_core::block_header_state_core( uint32_t last_final_blk_ht, | ||
| std::optional<uint32_t> final_on_strong_qc_blk_ht, | ||
| std::optional<uint32_t> last_qc_blk_ht ) |
There was a problem hiding this comment.
maybe spell out block_height everywhere (instead of blk_ht)so it is consistent throughout (like on line 34).
greg7mdp
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #1912. It implements
block_header_state_core(to hold hotstuff core information associated with each block) and its state transitions.Extensive unit tests are added.
Part 2 for qc_chain to track the state will be in a separate PR.