From 5aca7577d9799d0f157567f17af51ea84dc593ca Mon Sep 17 00:00:00 2001 From: Lin Huang Date: Fri, 27 Oct 2023 10:10:22 -0400 Subject: [PATCH] fix signedness warnings --- .../net_plugin/tests/rate_limit_parse_unittest.cpp | 14 +++++++------- .../state_history_plugin/tests/session_test.cpp | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/plugins/net_plugin/tests/rate_limit_parse_unittest.cpp b/plugins/net_plugin/tests/rate_limit_parse_unittest.cpp index 01c84e8a67..efd0cc36b7 100644 --- a/plugins/net_plugin/tests/rate_limit_parse_unittest.cpp +++ b/plugins/net_plugin/tests/rate_limit_parse_unittest.cpp @@ -20,25 +20,25 @@ BOOST_AUTO_TEST_CASE(test_parse_rate_limit) { size_t which = 0; auto [listen_addr, block_sync_rate_limit] = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "0.0.0.0:9876"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 0); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 0u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "0.0.0.0:9776"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 0); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 0u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "0.0.0.0:9877"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 640000); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 640000u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "192.168.0.1:9878"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 20971520); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 20971520u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "localhost:9879"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 500); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 500u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "[2001:db8:85a3:8d3:1319:8a2e:370:7348]:9876"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 250000); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 250000u); std::tie(listen_addr, block_sync_rate_limit) = plugin_impl.parse_listen_address(p2p_addresses[which++]); BOOST_CHECK_EQUAL(listen_addr, "[::1]:9876"); - BOOST_CHECK_EQUAL(block_sync_rate_limit, 250000); + BOOST_CHECK_EQUAL(block_sync_rate_limit, 250000u); BOOST_CHECK_EXCEPTION(plugin_impl.parse_listen_address(p2p_addresses[which++]), eosio::chain::plugin_config_exception, [](const eosio::chain::plugin_config_exception& e) {return std::strstr(e.top_message().c_str(), "IPv6 addresses must be enclosed in square brackets");}); diff --git a/plugins/state_history_plugin/tests/session_test.cpp b/plugins/state_history_plugin/tests/session_test.cpp index 63b260040c..e1bc439ef2 100644 --- a/plugins/state_history_plugin/tests/session_test.cpp +++ b/plugins/state_history_plugin/tests/session_test.cpp @@ -485,7 +485,7 @@ BOOST_FIXTURE_TEST_CASE(test_split_log, state_history_test_fixture) { eosio::state_history::state_result result; // we should get 1023 consecutive block result eosio::chain::block_id_type prev_id; - for (int i = 0; i < head; ++i) { + for (uint32_t i = 0; i < head; ++i) { receive_result(result); BOOST_REQUIRE(std::holds_alternative(result)); auto r = std::get(result);