Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Move perf tests to benchmark #2371

Closed
heifner opened this issue Apr 2, 2024 · 1 comment · Fixed by #2375
Closed

IF: Move perf tests to benchmark #2371

heifner opened this issue Apr 2, 2024 · 1 comment · Fixed by #2375
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Instant Finality:...

Comments

@heifner
Copy link
Member

heifner commented Apr 2, 2024 •
edited
Loading

merkle_tree_tests perf_test_many_small and perf_test_one_large should be moved to ./benchmark. They take a long time to run and they output to cout which is not appropriate for unittests.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Apr 2, 2024
@spoonincode
Copy link
Member

there is also modexp_benchmarking unit test which is similarly outputting to stdout and not really a unit test

@greg7mdp greg7mdp self-assigned this Apr 3, 2024
@greg7mdp greg7mdp mentioned this issue Apr 3, 2024
Merged
@greg7mdp greg7mdp added 👍 lgtm and removed triage labels Apr 3, 2024
@greg7mdp greg7mdp moved this from Todo to Reviewer Approved in Team Backlog Apr 3, 2024
@greg7mdp greg7mdp moved this from Reviewer Approved to Done in Team Backlog Apr 3, 2024
@greg7mdp greg7mdp closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Instant Finality: Production-Ready
Development

Successfully merging a pull request may close this issue.

IF: Move perf tests to benchmark AntelopeIO/leap
4 participants
@greg7mdp @heifner @spoonincode @enf-ci-bot