You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We determined that the addition of two new tests in #2335 caused a string of workflow failures, causing at least one failure for just about every commit. Failures are in NP, LR, ubsan, asan, asserton workflows.
Since we need the new tests in order to run validations both with and without Savanna activated, we need to beef-up the instances the workflow VMs are running on.
We determined that, even before the systematic failures, the tests were running extremely slowly.
In order to provide reliable ci/cd workflows, and to provide some buffer so that the issue doesn't reoccur as soon as we add a few new tests, I feel that we should at least double the number of cores per instance (or the equivalent if each core is faster), provided the cost is not prohibitive.
This increase should apply to the following workflows: NP, LR, ubsan, asan, asserton
The text was updated successfully, but these errors were encountered:
greg7mdp
changed the title
IF: workflow fail because of newly added tests in hotstuff_integration branch
IF: workflows fail because of newly added tests in hotstuff_integration branch
Apr 2, 2024
We determined that the addition of two new tests in #2335 caused a string of workflow failures, causing at least one failure for just about every commit. Failures are in
NP
,LR
,ubsan
,asan
,asserton
workflows.Two workflow runs, using
hotstuff_integration
with just these tests removed, passed without problems. See https://github.com/AntelopeIO/leap/actions/runs/8523025337.Since we need the new tests in order to run validations both with and without Savanna activated, we need to beef-up the instances the workflow VMs are running on.
We determined that, even before the systematic failures, the tests were running extremely slowly.
In order to provide reliable ci/cd workflows, and to provide some buffer so that the issue doesn't reoccur as soon as we add a few new tests, I feel that we should at least double the number of cores per instance (or the equivalent if each core is faster), provided the cost is not prohibitive.
This increase should apply to the following workflows:
NP
,LR
,ubsan
,asan
,asserton
The text was updated successfully, but these errors were encountered: