Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Genesis block state finality digest correction #2348

Closed
Tracked by #2110
arhag opened this issue Mar 27, 2024 · 0 comments · Fixed by #2353
Closed
Tracked by #2110

IF: Genesis block state finality digest correction #2348

arhag opened this issue Mar 27, 2024 · 0 comments · Fixed by #2353
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@arhag
Copy link
Member

arhag commented Mar 27, 2024

When converting a genesis block_state_legacy into a block_state, the validation tree constructed for the block_state includes a single leaf node (the one for the genesis block).

Currently, that leaf node assumes an empty digest for the finality digest of the genesis block. It should instead compute the digest from the constructed block_header_state.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 27, 2024
@arhag arhag removed the triage label Mar 27, 2024
@arhag arhag mentioned this issue Mar 27, 2024
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Mar 28, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Mar 28, 2024
heifner added a commit that referenced this issue Mar 28, 2024
@heifner
GH-2348 Calculate IF Genesis Block finality digest correctly
86cca8e
@heifner heifner mentioned this issue Mar 28, 2024
Merged
@heifner heifner linked a pull request Mar 28, 2024 that will close this issue
IF: Calculate IF Genesis Block finality digest correctly #2353
Merged
heifner added a commit that referenced this issue Mar 28, 2024
@heifner
GH-2348 Make sure all attributes of block_state are populated in crea…
acc51cb 
…te_if_genesis_block. Avoid calculating strong_digest twice by providing it to new_valid().
heifner added a commit that referenced this issue Mar 28, 2024
@heifner
Merge branch 'hotstuff_integration' into GH-2348-genesis-finality-digest
f0fcc44
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Mar 28, 2024
heifner added a commit that referenced this issue Mar 29, 2024
@heifner
Merge branch 'hotstuff_integration' into GH-2348-genesis-finality-digest
809e4ab
heifner added a commit that referenced this issue Mar 29, 2024
@heifner
GH-2348 Use correct strong digest
0d809ef
heifner added a commit that referenced this issue Mar 29, 2024
@heifner
GH-2348 Fix spelling
46867a9
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Mar 29, 2024
heifner added a commit that referenced this issue Mar 29, 2024
@heifner
Merge pull request #2353 from AntelopeIO/GH-2348-genesis-finality-digest
5b83d32 
IF: Calculate IF Genesis Block finality digest correctly
@heifner heifner closed this as completed Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Calculate IF Genesis Block finality digest correctly AntelopeIO/leap
4 participants
@heifner @arhag @enf-ci-bot @BenjaminGormanPMP