Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: add get_blocks_result_v1 to SHiP #2340

Closed
Tracked by #2110
linh2931 opened this issue Mar 27, 2024 · 0 comments · Fixed by #2349
Closed
Tracked by #2110

IF: add get_blocks_result_v1 to SHiP #2340

linh2931 opened this issue Mar 27, 2024 · 0 comments · Fixed by #2349
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Mar 27, 2024

This is a placeholder for a possible issue.

#2321 adds SHiP support for IBC. In the ABI definition and type, we introduce a new get_blocks_request_v1 which includes a field fetch_finality_data, but we reuse get_blocks_result_v0 by adding an { "name": "finality_data", "type": "bytes?" } to the bottom. Our code makes sure no finality_data be written to binary SHiP log in Legacy mode. But if a client uses ABI bin_to_json() to convert the binary to JSON based on get_blocks_result_v0, the ABI converter will add an extra "finality_data": null to the JSON output.

A solution would be to add get_blocks_result_v1 to include finality_data and leave get_blocks_result_v0 alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants