You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2321 adds SHiP support for IBC. In the ABI definition and type, we introduce a new get_blocks_request_v1 which includes a field fetch_finality_data, but we reuse get_blocks_result_v0 by adding an { "name": "finality_data", "type": "bytes?" } to the bottom. Our code makes sure no finality_data be written to binary SHiP log in Legacy mode. But if a client uses ABI bin_to_json() to convert the binary to JSON based on get_blocks_result_v0, the ABI converter will add an extra "finality_data": null to the JSON output.
A solution would be to add get_blocks_result_v1 to include finality_data and leave get_blocks_result_v0 alone.
The text was updated successfully, but these errors were encountered:
This is a placeholder for a possible issue.
#2321 adds
SHiP
support for IBC. In the ABI definition and type, we introduce a new get_blocks_request_v1 which includes a field fetch_finality_data, but we reuse get_blocks_result_v0 by adding an { "name": "finality_data", "type": "bytes?" } to the bottom. Our code makes sure no finality_data be written to binary SHiP log in Legacy mode. But if a client uses ABI bin_to_json() to convert the binary to JSON based on get_blocks_result_v0, the ABI converter will add an extra "finality_data": null to the JSON output.A solution would be to add
get_blocks_result_v1
to include finality_data and leave get_blocks_result_v0 alone.The text was updated successfully, but these errors were encountered: