IF: Test Failure: nodeos_producer_watermark_if_lr_test

[linh2931]

To investigate later:
https://github.com/AntelopeIO/leap/actions/runs/8210228195/job/22457515541?pr=2282#step:4:10111

[heifner]

Looks like a failure of immediate transition to instant finality.

The setfinalizer is called but the transaction does not fit in the block so it is put in the next block. However, the switch to instant finality does happen:

info  2024-03-08T23:43:14.770 nodeos    controller.cpp:2944           operator()           ] Transition to instant finality happening after block 50

The txt is then put into block 51, but 51 never reaches LIB because we transitioned in block 50.

The 51 block never reaches LIB.

If we wished to fix this, then we would need to verify the txt (and block) did not fail before switching.

debug 2024-03-08T23:43:14.737 nodeos    producer_plugin.cpp:2248      handle_push_result   ] [TRX_TRACE] Block 50 for producer eosio COULD NOT FIT, tx: 22dff997d9c8df0133c60bb1580e267202308637b069b771f1b0665c63e338f4 RETRYING 
debug 2024-03-08T23:43:14.796 nodeos    producer_plugin.cpp:2145      log_trx_results      ] [TRX_TRACE] Block 51 for producer eosio is ACCEPTING tx: 22dff997d9c8df0133c60bb1580e267202308637b069b771f1b0665c63e338f4, auth: eosio, cpu: 23830
debug 2024-03-08T23:43:14.797 nodeos    producer_plugin.cpp:2152      log_trx_results      ] [TRX_TRACE] Block 51 for producer eosio is ACCEPTING tx: {"id":"22dff997d9c8df0133c60bb1580e267202308637b069b771f1b0665c63e338f4","block_num":51,"block_time":"2024-03-08T23:43:15.500","producer_block_id":null,"receipt":{"status":"executed","cpu_usage_us":23830,"net_usage_words":232},"elapsed":23830,"net_usage":1856,"scheduled":false,"action_traces":[{"action_ordinal":1,"creator_action_ordinal":0,"closest_unnotified_ancestor_action_ordinal":0,"receipt":{"receiver":"eosio","act_digest":"d0c6c42b21bb71c8473513f6007658a8a665e6500901a2f9f4093f13890e26aa","global_sequence":79,"recv_sequence":77,"auth_sequence":[["eosio",77]],"code_sequence":2,"abi_sequence":2},"receiver":"eosio","act":{"account":"eosio","name":"setfinalizer","authorization":[{"actor":"eosio","permission":"active"}],"data":{"finalizer_policy":{"threshold":3,"finalizers":[{"description":"finalizer #1","weight":1,"public_key":"PUB_BLS_FkgMTontJR4PksDzsaoY6asz6u1K1Doni-lxQ9MOONzOACFzGPTJsWWjaZDybcoT9kMq_qcmOQtIX_RtPK4eRMicQRD_vf5qfAs0ahq7yg6LdBHhWAf_YLPe476FTZcMfPUAuA","pop":"SIG_BLS_8ZknHDph-_sl5ytPPtWDIkLVB2F359pkBergg4kX0d2CaJrHtiiA7FHQvrhr4jwDHV6_DY8A04kFEJ8Ez3tfx1sEEPzXpnkzfur04fyqp9meW7SDC4kUcXVCnAhC1xIP00uwByb6d8dxIGKgmieQckqPk9e3F9bVqp_uj9N00K5fmBJpliz13DwOeROkxXUWvIFmOq1pFc-XRSFenYvY9Ke64CMEP3vhX-8jHc03vWb1FFbTag80oIeh_V2-bsoND-pHWw"},{"description":"finalizer #2","weight":1,"public_key":"PUB_BLS_H1V7cbQ1FD4ClKyz1V8FXpVFNvUygXqf0N9uLf2ivP7PMdQfNyJcZgeMXgdhg38W35DnUNzF8GZQFjuj50Cr4H5s222M2NHNTclONh1U8ID-KYEJ3mKd83rorNpNs5YJKxcKVw","pop":"SIG_BLS_GuE689wf8DqPeP6Um3xPau_mgNML68xBADjrk_xidHqF_6PRSQ3vdVTEndOpKZoF84rwNOJjKUowjQ78mO8j0KVxlue_LWW55MI2GlrupfF3VHVmXyAcDsRYqsazJskLcHqiUMMk8hEJoYa-Pv2c0F62kLpuuMVepcbGCCbDBL_0duOLdYSokr7E0WFSORkUmeDhe6OnGjhpi4vzBn6a9WV1Q8C8VmnvSYB7D3nuAZC77fiPQRWWKlumIh9SHRMMd_IU1A"},{"description":"finalizer #3","weight":1,"public_key":"PUB_BLS_2CVIBcIn0Zyidc9kAFaNK39YSSiOfJ6WRJ0Yr6tr99TmrzN5uJMIMWtr5ZTE0noIYal9Lvk2UZs2WyJrUkgKheAr2HMWJ2Vkz4YGFZNFCr6kBZApOAWB3fW_iq-LcAkNHM1ElA","pop":"SIG_BLS_R_X8wdLJBcHwVaKf7_IdtE-bKggKowHosq2OueNzJdMUX-FTpfYsOu86KqnA0lYWz3-0STgBLvi7684SZTkPXBabj2sGde4McUFEiaO2y3i2lvebsMJuZgPYV-Liy8MPg0u05zyJowbv-jIhCljLClqQloC2shH42FHhgODBsnaVw0y8-kHhSwHDa08L6VMS6ot4wpar1Y2l-OAzTCPzrOuoqyC2u7GzcPR2sGgEBsVMaw2ulUlVpUGTiF3YwuoGR_Rblg"},{"description":"finalizer #4","weight":1,"public_key":"PUB_BLS_qVbh4IjYZpRGo8U_0spBUM-u-r_G0fMo4MzLZRsKWmm5uyeQTp74YFaMN9IDWPoVVT5rj_Tw1gvps6K9_OZ6sabkJJzug3uGfjA6qiaLbLh5Fnafwv-nVgzzzBlU2kwRrcHc8Q","pop":"SIG_BLS_L5MXQpJTX_v7cXDy4ML4fWVw_69MKuG5qTq7dD_Zb3Yuw1RbMXBOYXDoAbFF37gFmHudY3kkqXtETLs9nMTjTaTwgdDZWpFy1_csEIZT-xIOQttc76bpZhI67902g2sIDf6JSf9JtbhdTUc_HNbL7H2ZR2bqGS3YPbV5z7x24AR2vwTcJogMqLyy6H5nKQAEwIvXcL15gbs2EkH_ch-IZDdn4F0zUYifpOo-ovXY_CX_yL2rKIx_2a9IHg0pPrMOdfHs9A"}]}},"hex_data":{"size":1757,"trimmed_hex":"0300000000000000040c66696e616c697a657220233101000000000000008e015055425f424c535f466b674d546f6e744a5234506b73447a73616f593661737a"}},"context_free":false,"elapsed":23747,"console":"","trx_id":"22dff997d9c8df0133c60bb1580e267202308637b069b771f1b0665c63e338f4","block_num":51,"block_time":"2024-03-08T23:43:15.500","producer_block_id":null,"account_ram_deltas":[],"except":null,"error_code":null,"return_value_hex_data":""}],"account_ram_delta":null,"except":null,"error_code":null}

[arhag]

Closing because we believe implementing proper IF transition (rather than immediate transition) resolved the test failure.