Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error reporting on snapshot failure #2293

Closed
heifner opened this issue Mar 8, 2024 · 0 comments · Fixed by #2294 or #2295
Closed

Better error reporting on snapshot failure #2293

heifner opened this issue Mar 8, 2024 · 0 comments · Fixed by #2294 or #2295
Assignees
@heifner
Labels
OCI Work exclusive to OCI team triage
Milestone
Leap v5.0.4

Comments

@heifner
Copy link
Member

heifner commented Mar 8, 2024 •
edited by spoonincode
Loading

Currently istream_snapshot_reader::validate() catches std::exception and prints the what. This hides useful information of any fc::exception that is thrown. Should add a case for fc::exception and provide more information; or better yet just replace with FC_LOG_AND_RETHROW( ).
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 8, 2024
@heifner heifner self-assigned this Mar 8, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Mar 8, 2024
@heifner heifner added this to the Leap v5.0.3 milestone Mar 8, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Mar 8, 2024
heifner added a commit that referenced this issue Mar 8, 2024
@heifner
GH-2293 Use FC_LOG_AND_RETHROW to provide better error reporting.
5d270fd
@heifner heifner mentioned this issue Mar 8, 2024
Merged
@heifner heifner linked a pull request Mar 8, 2024 that will close this issue
[5.0] Better error reporting on snapshot load exceptions #2294
Merged
heifner added a commit that referenced this issue Mar 8, 2024
@heifner
Merge pull request #2294 from AntelopeIO/GH-2293-snapshot-error
b4dc3b6 
[5.0] Better error reporting on snapshot load exceptions
heifner added a commit that referenced this issue Mar 8, 2024
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-2293-snapsh…
270fb70 
…ot-error-main
@heifner heifner mentioned this issue Mar 8, 2024
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Mar 8, 2024
heifner added a commit that referenced this issue Mar 8, 2024
@heifner
Merge pull request #2295 from AntelopeIO/GH-2293-snapshot-error-main
968a0fa 
[5.0 -> main] Better error reporting on snapshot load exceptions
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
OCI Work exclusive to OCI team triage
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.4
2 participants
@heifner @enf-ci-bot