Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compute_transaction API endpoint response changed #2281

Closed
aaroncox opened this issue Mar 5, 2024 · 0 comments · Fixed by AntelopeIO/spring#477
Closed

The compute_transaction API endpoint response changed #2281

aaroncox opened this issue Mar 5, 2024 · 0 comments · Fixed by AntelopeIO/spring#477
Assignees
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Milestone

Comments

@aaroncox
Copy link
Contributor

aaroncox commented Mar 5, 2024

Somewhere between 4.x and 5.x the way the /v1/chain/compute_transaction API endpoint changed how it responds when errors occur, which is causing it to be more difficult to use the endpoint to calculate resource requirements.

Previously it would allow the transaction to "process" and return any errors that occurred in the processed.except field with a nice error stack. If there was a tx_cpu_usage_exceeded exception, it would return the data alongside afield to easily access the stack[0].data.billed required for the transaction.

Now in post 5.x, it's throwing an actual 500 error as the response with more limited data as an error string, and no error stack.

What are the chances we can revert and go back to the previous behavior?

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 5, 2024
@bhazzard bhazzard added bug Something isn't working 👍 lgtm and removed triage labels Mar 12, 2024
@bhazzard bhazzard added this to the Leap v5.0.3 milestone Mar 12, 2024
@heifner heifner self-assigned this Aug 5, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 5, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 5, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 5, 2024
heifner added a commit that referenced this issue Aug 5, 2024
[5.0] compute_transaction should return failure trace
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants