Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE features as prerequisite for the activation of the instant_finality feature #2162

Closed
systemzax opened this issue Jan 30, 2024 · 2 comments · Fixed by #2318
Assignees

Comments

@systemzax
Copy link
Member

systemzax commented Jan 30, 2024

INSTANT_FINALITY should have prerequisite:

  • ACTION_RETURN_VALUE is desired so that the IBC contract can use it. Also it changes the algorithm for digest computation and don't want IBC to have to handle both ways.
  • WTMSIG_BLOCK_SIGNATURES Changes the algorithm for digest computation and don't want the IBC to handle both ways. Also we do not need to check if WTMSIG_BLOCK_SIGNATURES is activated in block_header_state::next.
  • DISALLOW_EMPTY_PRODUCER_SCHEDULE Using the same set_proposed_producers which checks this protocol feature. We do not want empty proposer schedules.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 30, 2024
@arhag arhag added 👍 lgtm and removed triage labels Jan 31, 2024
@arhag arhag changed the title IF: Add the activation of action_return_value feature as prerequisite for the activation of the instant_finality feature IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE feature as prerequisite for the activation of the instant_finality feature Feb 5, 2024
@arhag arhag changed the title IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE feature as prerequisite for the activation of the instant_finality feature IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE features as prerequisite for the activation of the instant_finality feature Feb 5, 2024
@heifner
Copy link
Member

heifner commented Feb 16, 2024

I wonder if it is useful to draw a line in the sand and make INSTANT_FINALITY depend on all previous protocol features. Going forward all new protocol features could depend on INSTANT_FINALITY. If we ever mint a new genesis we could clean up all the existing protocol feature differences.

@greg7mdp
Copy link
Contributor

greg7mdp commented Mar 15, 2024

Should we also make INSTANT_FINALITY depend on BLS_PRIMITIVES2 and WEBAUTHN_KEY which I believe are required for the BIOS contract?

Areg: yes for BLS_PRIMITIVES2

@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Mar 15, 2024
@greg7mdp greg7mdp moved this from In Progress to Awaiting Review in Team Backlog Mar 16, 2024
@greg7mdp greg7mdp moved this from Awaiting Review to Done in Team Backlog Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants