You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE features as prerequisite for the activation of the instant_finality feature
#2162
Closed
systemzax opened this issue
Jan 30, 2024
· 2 comments
· Fixed by #2318
ACTION_RETURN_VALUE is desired so that the IBC contract can use it. Also it changes the algorithm for digest computation and don't want IBC to have to handle both ways.
WTMSIG_BLOCK_SIGNATURES Changes the algorithm for digest computation and don't want the IBC to handle both ways. Also we do not need to check if WTMSIG_BLOCK_SIGNATURES is activated in block_header_state::next.
DISALLOW_EMPTY_PRODUCER_SCHEDULE Using the same set_proposed_producers which checks this protocol feature. We do not want empty proposer schedules.
The text was updated successfully, but these errors were encountered:
arhag
changed the title
IF: Add the activation of action_return_value feature as prerequisite for the activation of the instant_finality feature
IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE feature as prerequisite for the activation of the instant_finality feature
Feb 5, 2024
arhag
changed the title
IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE feature as prerequisite for the activation of the instant_finality feature
IF: Add the activation of WTMSIG_BLOCK_SIGNATURES and ACTION_RETURN_VALUE features as prerequisite for the activation of the instant_finality feature
Feb 5, 2024
I wonder if it is useful to draw a line in the sand and make INSTANT_FINALITY depend on all previous protocol features. Going forward all new protocol features could depend on INSTANT_FINALITY. If we ever mint a new genesis we could clean up all the existing protocol feature differences.
INSTANT_FINALITY
should have prerequisite:ACTION_RETURN_VALUE
is desired so that the IBC contract can use it. Also it changes the algorithm for digest computation and don't want IBC to have to handle both ways.WTMSIG_BLOCK_SIGNATURES
Changes the algorithm for digest computation and don't want the IBC to handle both ways. Also we do not need to check ifWTMSIG_BLOCK_SIGNATURES
is activated inblock_header_state::next
.DISALLOW_EMPTY_PRODUCER_SCHEDULE
Using the sameset_proposed_producers
which checks this protocol feature. We do not want empty proposer schedules.The text was updated successfully, but these errors were encountered: