Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Bring back is_needed to avoid adding redundant QCs to blocks; enforce sensible finalizer policy in setfinalizers #2136

Closed
Tracked by #2110
arhag opened this issue Jan 24, 2024 · 0 comments · Fixed by #2137
Closed
Tracked by #2110

IF: Bring back is_needed to avoid adding redundant QCs to blocks; enforce sensible finalizer policy in setfinalizers #2136

arhag opened this issue Jan 24, 2024 · 0 comments · Fixed by #2137
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@arhag
Copy link
Member

arhag commented Jan 24, 2024 •
edited
Loading

If the QC claim in the to-be-assembled block is the same (same block number and strong/weak status) as the QC claim in the previous block, then the QC should not be included in the block extension.

Also, within the setfinalizers host function, assert that the sum of the weights is greater than or equal to the threshold.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 24, 2024
@arhag arhag added 👍 lgtm and removed triage labels Jan 24, 2024
@arhag arhag mentioned this issue Jan 24, 2024
Closed
@arhag arhag changed the title IF: Bring back is_needed to avoid adding redundant QCs to blocks IF: Bring back is_needed to avoid adding redundant QCs to blocks; enforce sensible finalizer policy in setfinalizers Jan 24, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jan 25, 2024
@linh2931 linh2931 mentioned this issue Jan 25, 2024
Merged
@heifner heifner linked a pull request Jan 25, 2024 that will close this issue
IF: Bring back is_needed to avoid adding redundant QCs to blocks; enforce sensible finalizer policy in setfinalizers host function #2137
Merged
@linh2931 linh2931 moved this from In Progress to Done in Team Backlog Jan 26, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
4 participants
@arhag @linh2931 @enf-ci-bot @BenjaminGormanPMP