Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When mapped_private doesn't work, database is left dirty #2086

Closed
eosusa opened this issue Jan 15, 2024 · 1 comment · Fixed by AntelopeIO/chainbase#38, #2132, #2134 or AntelopeIO/chainbase#40
Assignees
Labels
bug Something isn't working 👍 lgtm
Milestone

Comments

@eosusa
Copy link

eosusa commented Jan 15, 2024

When I tried to flip a server running 5.0 to the new "mapped_private" memory mode, I encountered the following error (because my chain state db setting was higher than mem on the server):

rethrow Cannot allocate memory:
    {"what":"Cannot allocate memory"}
    nodeos  chain_plugin.cpp:1102 plugin_initialize

The problem is that when i flipped the mode back to the default "mapped" mode, it left the state dirty and I had to use a snapshot to recover it (which Kevin said is not the expected behavior).

@spoonincode spoonincode added bug Something isn't working 👍 lgtm and removed triage labels Jan 15, 2024
@greg7mdp
Copy link
Contributor

This is an easy fix imo. When in mapped_private mode, I don't believe we need to mark the database dirty at startup, since we don't change it until exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment