Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: make constant members of block_state and block_header_state const. Make block_header_state a member. of block_state. #2082

Closed
Tracked by #2110
greg7mdp opened this issue Jan 12, 2024 · 0 comments

Comments

@greg7mdp
Copy link
Contributor

greg7mdp commented Jan 12, 2024

In addition to documenting which members don't change, it will allow to add a std::mutex to pending_qc , which will allow safe access from multiple net_plugin threads for aggregating votes.

It will require (at least) making block_header_state inside assembled_block_if a unique_ptr, because const members are not movable.

Also, probably less importantly, make block_header_state a member of block_state instead of inheriting from it.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 12, 2024
@greg7mdp greg7mdp added 👍 lgtm and removed triage labels Jan 12, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
@arhag arhag removed this from the Leap v6.0.0-rc1 milestone Feb 23, 2024
@arhag arhag closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants