Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Unification: implement get_best_qc in block_state #2075

Closed
Tracked by #1508
linh2931 opened this issue Jan 11, 2024 · 0 comments · Fixed by #2076
Closed
Tracked by #1508

IF: Unification: implement get_best_qc in block_state #2075

linh2931 opened this issue Jan 11, 2024 · 0 comments · Fixed by #2076
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

linh2931 commented Jan 11, 2024 •
edited
Loading

get_best_qc is needed when finding the most recent ancestor QC.

If pending_qc does not have a valid QC, return valid_qc. Otherwise, extract the valid QC from pending_qc. Compare that to valid_qc to determine which is better: Strong beats Weak. Break tie with highest accumulated weight. Return the better one.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 11, 2024
@linh2931 linh2931 self-assigned this Jan 11, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jan 11, 2024
@linh2931 linh2931 mentioned this issue Jan 11, 2024
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Jan 11, 2024
@linh2931 linh2931 linked a pull request Jan 11, 2024 that will close this issue
IF: Unification: Implement get_best_qc in block_state #2076
Merged
@arhag arhag mentioned this issue Jan 11, 2024
Closed
@linh2931 linh2931 added this to the Leap v6.0.0-rc1 milestone Jan 12, 2024
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Unification: Implement get_best_qc in block_state AntelopeIO/leap
2 participants
@linh2931 @enf-ci-bot