Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Unification: Sign finalizer_digest of received block header and send out vote #2069

Closed
Tracked by #1508
arhag opened this issue Jan 10, 2024 · 0 comments · Fixed by #2087
Closed
Tracked by #1508

IF: Unification: Sign finalizer_digest of received block header and send out vote #2069

arhag opened this issue Jan 10, 2024 · 0 comments · Fixed by #2087
Assignees

Comments

@arhag
Copy link
Member

arhag commented Jan 10, 2024

First validate the block header and use it to compute the next block_header_state. The block_header_state should compute the finalizer_digest. This should be done as part of receiving the block.

Afterward, without blocking the signal of receiving the block, the configured finalizers of the node should attempt to sign that block asynchronously, either the finalizer_digest or the weak digest computed from the finalizer_digest and a tag indicating WEAK, depending on whether the finalizer chooses to sign strong or weak, respectively. A new signal will need to be added to let the net_plugin know there is a new vote message that is ready to broadcast.

For this issue, the finalizer should always sign strongly. This will be refined in a later issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants