Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: use the same way to determine if instant finality is active #2028

Closed
Tracked by #1508
linh2931 opened this issue Jan 3, 2024 · 0 comments · Fixed by #2043
Closed
Tracked by #1508

IF: use the same way to determine if instant finality is active #2028

linh2931 opened this issue Jan 3, 2024 · 0 comments · Fixed by #2043
Assignees
@linh2931
Labels
👍 lgtm

Comments

@linh2931
Copy link
Member

linh2931 commented Jan 3, 2024

https://github.com/AntelopeIO/leap/pull/2024/files#r1440617405

The presence of instant_finality_extension should be used as an indication of instant finality activated. But doing that fails unit test producer_schedule_hs_tests/verify_producer_schedule_after_hotstuff_activation with

3030000 block_validate_exception: Block exception
invalid block transaction merkle root 0cb3d1d90b7b4d61b7db5cb3730bee81f98d339cc1ac5fb0c1b50ddc12e9e108 != b26dc703930e4f88b4dffa3a24af3a580009ffaa83a8d50e4bdbc397db729d8f
    {"b":"0cb3d1d90b7b4d61b7db5cb3730bee81f98d339cc1ac5fb0c1b50ddc12e9e108","c":"b26dc703930e4f88b4dffa3a24af3a580009ffaa83a8d50e4bdbc397db729d8f"}
    chain-1  controller.cpp:2226 create_block_state_i
rethrow

Additional work is required for the transition from DPOS to Instant Finality.
This was referenced Jan 3, 2024
Closed
Merged
@linh2931 linh2931 self-assigned this Jan 4, 2024
@linh2931 linh2931 added 👍 lgtm and removed triage labels Jan 4, 2024
@linh2931 linh2931 mentioned this issue Jan 5, 2024
Merged
@linh2931 linh2931 moved this from Todo to Awaiting Review in Team Backlog Jan 5, 2024
@linh2931 linh2931 linked a pull request Jan 5, 2024 that will close this issue
IF: use the same way to determine if instant finality is active #2043
Merged
@linh2931 linh2931 changed the title IF: Additional work for transition from DPOS to Instant Finality IF: use the same way to determine if instant finality is active Jan 5, 2024
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Jan 6, 2024
@arhag arhag closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: use the same way to determine if instant finality is active AntelopeIO/leap
3 participants
@arhag @linh2931 @enf-ci-bot