Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: copy new eosio.bios from reference-contract repo to Leap libtester and add more validations to set_finalizers host function #1987

Closed
Tracked by #2110
linh2931 opened this issue Dec 14, 2023 · 0 comments · Fixed by #1989
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Dec 14, 2023

Copy eosio.bios contract from AntelopeIO/reference-contracts#33

In addition, from @arhag in Telegram as a result of the review of AntelopeIO/reference-contracts#33

We could have overflows in f_weight_sum in set_finalizers. We should check for that in Leap.
Also, we should use check = true in Leap regardless of any assumptions we make about what the system contract may or may not do.

Continue using set as a means of detecting duplicates of public keys in set_finalizers. However, detect the duplicate early and if found throw an error where the message include the duplicate public key in its text encoding.

Either remove the operator == from bls_public_key and bls_signature or, if they are actually used, rename them equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment