Remove cpu-effort-percent and replace with new option

[eosusa]

Brian's Edits

Because the behavior of cpu-effort-percent has changed significantly, we should create a new option instead.

Suggestion noted on changing the default from 90% to 95%, will consider for a future release as we continue to receive feedback from production.

Decisions:

• Should we DEPRECATE cpu-effort-percent? No as this is a major release and the impact is limited to failure to start.
• What should we call the new option? produce-block-offset-ms
• What should the default value be? 450 ms

Remaining Tasks

• Add new option and default value
• Update documentation here: Block Producing Explained

Original Report

@eosusa's original title: "Rename cpu-effort-percentage to round-cpu-effort-percentage and default to 95%"

With the 5.0 RC2 release, the cpu-effort-percentage parameter functionality was dramatically changed from not controlling each individual block's cpu effort during signing, but now controls the ENTIRE round's cpu effort for ALL blocks cumulatively for the round.

While this is a great new feature to add, having it reuse the original parameter from previous versions that functioned differently I believe is a mistake and could easily clear up some confusion by simply renaming the new parameter vs.s reusing the original.

Also, on most public networks we operate on, the default of 90% round-cpu-effort-percentage is probably a bit too low as it kicks out the last block before it's scheduled time, which leads to some confusion because blocks are arriving early (and most networks don't have to send last block that aggressively). We've found most networks tend to function properly with the last block coming out about 300ms early, which would be roughly 95% round-cpu-effort-percentage I believe (if I understand it correctly, that is :))

[RalfWeinand]

I suggest to change the new option from a percentage to an offset in ms for better fine-tuning. The name could be something like “produce-block-offset-ms”. [A general suggestion for new parameter names is starting with the name of the plugin that it relates for easier grouping of related parameters in config.ini and in manual files. E.g. in this case the parameter is for the producer-plugin, so the parameter name starts with "producer-xyz".]

[bhazzard]

After discussion on the Node Operators call:

• Name the option produce-block-offset-ms
• Set the new default value to 450