Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example config.ini that matches old behaviour for "Support multiple http endpoints" 5.0 #1684

Closed
matthewdarwin opened this issue Sep 27, 2023 · 5 comments
Assignees

Comments

@matthewdarwin
Copy link

This PR allows much more configuration of which features are available on which ports: #1137

It would great if there was example that can be copy-pasted to enable exactly as in previous versions to make is easier to migrate.

http-server-address = http-category-address
http-category-address = node,127.0.0.1:8888
http-category-address = chain_ro,127.0.0.1:8888
http-category-address = chain_rw,127.0.0.1:8888
http-category-address = db_size,127.0.0.1:8888
http-category-address = net_ro,127.0.0.1:8888
http-category-address = net_rw,127.0.0.1:8888
http-category-address = producer_ro,127.0.0.1:8888
http-category-address = producer_rw,127.0.0.1:8888
http-category-address = snapshot,127.0.0.1:8888
http-category-address = prometheus,127.0.0.1:8888

However "node" seems to be an invalid type. So maybe the PR description is wrong?

@matthewdarwin matthewdarwin changed the title Provide example config.ini that matches old behaviour for "Support multiple http endpoints" Provide example config.ini that matches old behaviour for "Support multiple http endpoints" 5.0 Sep 27, 2023
@matthewdarwin
Copy link
Author

Background: #1681

@heifner
Copy link
Member

heifner commented Sep 27, 2023

"For the node category, it is NOT user configurable because it will be available for all listened http addresses."

That means node is not a configuration value, but rather just an indication that v1/node/get_supported_apis and v1/chain/get_info are available on all configured endpoints.

This is backward compatible with 4.0 configuration except for the prometheus-exporter-address which should be removed. If you use the same config.ini from 4.0 it will continue to listen on only one endpoint.

@bhazzard
Copy link

bhazzard commented Oct 2, 2023

@heifner so we're saying that we don't need an example, because the old config will work as it did before... do I have that right? If so, I'll make sure some mention of the backwards compatibility is mentioned in the upgrade guide and release notes.

@heifner
Copy link
Member

heifner commented Oct 2, 2023

@heifner so we're saying that we don't need an example, because the old config will work as it did before... do I have that right? If so, I'll make sure some mention of the backwards compatibility is mentioned in the upgrade guide and release notes.

That is correct.

@bhazzard bhazzard self-assigned this Oct 12, 2023
@bhazzard
Copy link

@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants