-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF : Extra padding is added to the hs_bitset when constructing a quorum_certificate from a quorum_certificate_message #1626
Comments
If I understand correctly, and the first bitset is for 21 finalizers and the second for 32 finalizers, I think the leading zeroes are meaningful, as the first output is exactly 21 binary digits and the second exactly 32, so in my opinion they should not be trimmed. |
The issue is that the conversion to "block" form out of We either need to implicitly know the finalizer set size (seems like we should know that) or pass along in the message how many of the provided bits are relevant (21 vs 32). |
Oh thanks, I get it now. |
Correct. |
Change |
Printing a quorum_certificate bitset when created :
Id : PVT_BLS_r4ZpChd87ooyzl6MIkw23k7PRX8xptp7TczLJHCIIW88h/hS finalizers 21 000000111111111111111
Printing a quorum_certificate bitset when received :
Id : PVT_BLS_/l7xzXANaB+GrlTsbZEuTiSOiWTtpBoog+TZnirxUUSaAfCo finalizers 32 00000000000000000111111111111111
The message format seems to (correctly) encode the bitset using the minimum required number of unsigned integers to represent the active finalizer set votes, but the decoding should also trim the extra leading zeroes.
The text was updated successfully, but these errors were encountered: