Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Implement finalizer policy change at appropriate time #1618

Closed
Tracked by #2110
greg7mdp opened this issue Sep 11, 2023 · 2 comments · Fixed by AntelopeIO/spring#19
Closed
Tracked by #2110

IF: Implement finalizer policy change at appropriate time #1618

greg7mdp opened this issue Sep 11, 2023 · 2 comments · Fixed by AntelopeIO/spring#19
Assignees

Comments

@greg7mdp
Copy link
Contributor

When a block containing a finalizer_set change proposal becomes final, we shouldn't switch to the new finalizer_set immediately, as different finalizers may receive the message at different time, and therefore not use the same finalizer_set.

So when a block containing a finalizer_set change proposal becomes final, the new finalizer_set should be pending until the next new_view message, allowing all finalizers to use the same finalizer_set in the new view.

@greg7mdp greg7mdp changed the title IF: Delay finalizer_set until next view IF: Delay finalizer_set change until next view Sep 11, 2023
@arhag
Copy link
Member

arhag commented Sep 19, 2023

Actually I think this should be delayed until another QC before switching finalizer sets. I think this is essential to maintain safety of the protocol despite finalizer set transitions.

EDIT: Actually waiting for another QC is not generally sufficient. We may need to wait for another 3-chain before it is safe to switch over to the new finality set.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Jan 16, 2024
@arhag arhag changed the title IF: Delay finalizer_set change until next view IF: Implement finalizer policy change at appropriate time Jan 22, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
@greg7mdp greg7mdp self-assigned this Apr 9, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Apr 9, 2024
@arhag
Copy link
Member

arhag commented Apr 29, 2024

We have an implementation of finalizer policy changes that works okay even if it is a little conservative. The proper algorithm can come later and is tracked in a new issue: AntelopeIO/spring#89.

@arhag arhag closed this as completed Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants