Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non privileged inline actions larger then 4KiB #1614

Closed
ericpassmore opened this issue Sep 9, 2023 · 2 comments · Fixed by #1645
Closed

Allow non privileged inline actions larger then 4KiB #1614

ericpassmore opened this issue Sep 9, 2023 · 2 comments · Fixed by #1645
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@ericpassmore
Copy link
Contributor

ericpassmore commented Sep 9, 2023

Remove max-non-privileged-inline-action-size option and the associated checks in the code. Add a test.

There is a 4 KiB limit on inline action size if the sender is not a privileged account. There isn't a business need for this constraint, and it makes our EOS-EVM integration more difficult. We cannot easily change the limit because it is subjectively enforced and we need to convince the whole network to change that config option. Instead we should update the code to no longer enforce this option.

Tasks

Preview Give feedback
No tasks being tracked yet.
@matthewdarwin
Copy link

Please don't have non-working configuration options. Remove the configuration option entirely.

@arhag
Copy link
Member

arhag commented Sep 11, 2023

I agree. We should just remove the option. It is a breaking change but we are allowed to do that in Leap 5.0 since it is a major version bump.

The change should also have a test that, while respecting the max inline action depth, creates many inline actions each with a size of 512 KiB just to confirm the Leap software handles it as expected even with the max-non-privileged-inline-action-size constraint removed.

@arhag arhag added this to the Leap v5.0.0-rc1 milestone Sep 14, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Sep 14, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Sep 14, 2023
heifner added a commit that referenced this issue Sep 15, 2023
…action_size limit and add new test for 512k limit
heifner added a commit that referenced this issue Sep 15, 2023
heifner added a commit that referenced this issue Sep 15, 2023
…d-inline-action-size

Remove max-nonprivileged-inline-action-size option
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants