From 2c8720efc22fbf3c64adfe8642db889dce556e11 Mon Sep 17 00:00:00 2001 From: Kevin Heifner Date: Sat, 26 Aug 2023 09:37:14 -0500 Subject: [PATCH] GH-1547 Address peer review comments --- libraries/chain/include/eosio/chain/hotstuff.hpp | 4 ++-- libraries/hotstuff/qc_chain.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/chain/include/eosio/chain/hotstuff.hpp b/libraries/chain/include/eosio/chain/hotstuff.hpp index 629d9333a0..eca54f4ec5 100644 --- a/libraries/chain/include/eosio/chain/hotstuff.hpp +++ b/libraries/chain/include/eosio/chain/hotstuff.hpp @@ -36,11 +36,11 @@ namespace eosio::chain { quorum_met = false; } - auto get_active_finalizers() const { + boost::dynamic_bitset<> get_active_finalizers() const { assert(!active_finalizers.empty()); return boost::dynamic_bitset(active_finalizers); } - void set_active_finalizers(const auto& bs) { + void set_active_finalizers(const boost::dynamic_bitset<>& bs) { assert(!bs.empty()); boost::to_string(bs, active_finalizers); } diff --git a/libraries/hotstuff/qc_chain.cpp b/libraries/hotstuff/qc_chain.cpp index 83859c57b2..bbc0fdd09d 100644 --- a/libraries/hotstuff/qc_chain.cpp +++ b/libraries/hotstuff/qc_chain.cpp @@ -237,7 +237,7 @@ namespace eosio { namespace hotstuff { fc::crypto::blslib::bls_public_key agg_key; for (boost::dynamic_bitset<>::size_type i = 0; i < finalizers.size(); i++) { - if (finalizers[i] == 1){ + if (finalizers[i]){ //adding finalizer's key to the aggregate pub key if (first) { first = false;