From cd8684f255f577b6810e281acaaf83b526a2464f Mon Sep 17 00:00:00 2001 From: Vincent Payet Date: Mon, 18 Dec 2023 14:44:50 +0100 Subject: [PATCH 1/2] [DEV] Remove yuni warnings --- .github/workflows/ubuntu.yml | 2 +- .github/workflows/windows-vcpkg.yml | 2 +- src/ext/yuni/src/yuni/core/atomic/int.hxx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 15d84bc5e9..58fb126257 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -203,7 +203,7 @@ jobs: os: ${{ matrix.test-platform }} - name: Run parallel tests - if: ${{ env.RUN_EXTENDED_TESTS == 'true' }} + if: ${{ env.IS_PUSH == 'true' }} uses: ./.github/workflows/run-tests with: simtest-tag: ${{steps.simtest-version.outputs.prop}} diff --git a/.github/workflows/windows-vcpkg.yml b/.github/workflows/windows-vcpkg.yml index 22fd808a1f..5e3b059e5d 100644 --- a/.github/workflows/windows-vcpkg.yml +++ b/.github/workflows/windows-vcpkg.yml @@ -226,7 +226,7 @@ jobs: os: ${{ matrix.test-platform }} - name: Run parallel tests - if: ${{ env.RUN_EXTENDED_TESTS == 'true' }} + if: ${{ env.IS_PUSH == 'true' }} uses: ./.github/workflows/run-tests with: simtest-tag: ${{steps.simtest-version.outputs.prop}} diff --git a/src/ext/yuni/src/yuni/core/atomic/int.hxx b/src/ext/yuni/src/yuni/core/atomic/int.hxx index 769fa74a4d..0ee6dd00aa 100644 --- a/src/ext/yuni/src/yuni/core/atomic/int.hxx +++ b/src/ext/yuni/src/yuni/core/atomic/int.hxx @@ -90,13 +90,13 @@ inline Int::operator ScalarType() const template class TP> inline typename Int::ScalarType Int::operator++() { - return (threadSafe) ? Private::AtomicImpl::Operator::Increment(*this) : (++pValue); + return Private::AtomicImpl::Operator::Increment(*this); } template class TP> inline typename Int::ScalarType Int::operator--() { - return (threadSafe) ? Private::AtomicImpl::Operator::Decrement(*this) : (--pValue); + return Private::AtomicImpl::Operator::Decrement(*this); } template class TP> From 70cc22beec5b26365ec76fef2ca73b705c7cbcf8 Mon Sep 17 00:00:00 2001 From: Florian OMNES <26088210+flomnes@users.noreply.github.com> Date: Mon, 18 Dec 2023 17:55:35 +0100 Subject: [PATCH 2/2] Partial revert --- .github/workflows/ubuntu.yml | 2 +- .github/workflows/windows-vcpkg.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 58fb126257..15d84bc5e9 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -203,7 +203,7 @@ jobs: os: ${{ matrix.test-platform }} - name: Run parallel tests - if: ${{ env.IS_PUSH == 'true' }} + if: ${{ env.RUN_EXTENDED_TESTS == 'true' }} uses: ./.github/workflows/run-tests with: simtest-tag: ${{steps.simtest-version.outputs.prop}} diff --git a/.github/workflows/windows-vcpkg.yml b/.github/workflows/windows-vcpkg.yml index 5e3b059e5d..22fd808a1f 100644 --- a/.github/workflows/windows-vcpkg.yml +++ b/.github/workflows/windows-vcpkg.yml @@ -226,7 +226,7 @@ jobs: os: ${{ matrix.test-platform }} - name: Run parallel tests - if: ${{ env.IS_PUSH == 'true' }} + if: ${{ env.RUN_EXTENDED_TESTS == 'true' }} uses: ./.github/workflows/run-tests with: simtest-tag: ${{steps.simtest-version.outputs.prop}}