Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include link to an app jnlp, if available #22

Open
iz-sai opened this issue Nov 27, 2013 · 4 comments
Open

Feature request: include link to an app jnlp, if available #22

iz-sai opened this issue Nov 27, 2013 · 4 comments

Comments

@iz-sai
Copy link
Contributor

iz-sai commented Nov 27, 2013

Moscow State University collaborators ask about possibility to include links to jnlp of the applications (specifically Aladin) to the VO menu when these apps aren't yet launched and have jnlp available. Once the app is launched change its representation in the VO menu to the default one (just like it is now).

AnotherOneAckap added a commit that referenced this issue Nov 30, 2013
@AnotherOneAckap
Copy link
Owner

Like this?

@iz-sai
Copy link
Contributor Author

iz-sai commented Nov 30, 2013

Yep, perfect. The only problem is that when one clicks on this jnlp link it immediately disappears -- tested in Safari and Chrome. I think it either should be there until SAMP icon appears, or you can change link to just inactive info text, something like "Loading Aladin…". The last idea is more prone to errors as launching jnlp may require further user actions and if users fails to launch it in the end he/she will have always this strange message about loading application. So better leave active link until SAMP icon appears.

@iz-sai
Copy link
Contributor Author

iz-sai commented Nov 30, 2013

You can see your code in action at http://ocl.sai.msu.ru

AnotherOneAckap added a commit that referenced this issue Dec 4, 2013
Now it "freezes" on 5 sec with "Waiting..." text, after that you can try launch again
AnotherOneAckap added a commit that referenced this issue Dec 5, 2013
@iz-sai
Copy link
Contributor Author

iz-sai commented Dec 14, 2013

Very nice changes! Couple of comments:

  • if user clicks on Launch Aladin when connected to a SAMP hub, Aladin launches but its icon does not appear automatically before page reload
  • can we show an information message "Please double click on {name}.jnlp file you've just downloaded to launch {Name} application"? Presently you show "waiting..." status which holds only until jnlp file was downloaded, whereas we should probably keep it until the application is launched and … connected. Wouldn't it be reasonable then to make Launch Aladin / Launch TOPCAT links an equivalent to "on" button? Both application have built-in SAMP hub and browser client can try to connect. This maybe is not very clear from the UI point of view, but can be convenient to user I suppose, who just creates a session with the application he/she likes.

As usual, you can see what I describe at http://ocl.sai.msu.ru, I update it after your changes (it's running master branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants