Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards web standards 🎖️ #3355

Draft
wants to merge 103 commits into
base: master
Choose a base branch
from
Draft

Towards web standards 🎖️ #3355

wants to merge 103 commits into from

Conversation

ap-justin
Copy link
Collaborator

@ap-justin ap-justin commented Oct 10, 2024

Closes BG-1563
Towards BG-1530

Explanation of the solution

  • switch from location.state to search params e.g. _s, which is available to loaders
  • switch from marketplace context to search params
  • separate header containers (but reused contents) for home, app, admin pages

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn run test --watchAll to verify all tests still pass
  • (optional) run yarn run build to verify the build passes
  • run yarn start to start the webapp

UI changes for review

When major UI changes are introduced with a PR, please include links to URLS to compare or screenshots demonstrating the difference and notify on design changes

@ap-justin ap-justin changed the title use search params as state Migrate to server apis Oct 11, 2024
@ap-justin ap-justin changed the title Migrate to server apis Towards web standards 🎖️ Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant