-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards web standards 🎖️ #3355
Draft
ap-justin
wants to merge
103
commits into
master
Choose a base branch
from
reg-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Towards web standards 🎖️ #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap-justin
had a problem deploying
to
production
October 12, 2024 11:22
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 12, 2024 14:03
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 14, 2024 08:35
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 14, 2024 12:24
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 14, 2024 14:28
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 15, 2024 03:24
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 15, 2024 09:50
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
October 15, 2024 10:10
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
November 8, 2024 14:53
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
November 8, 2024 15:24
— with
GitHub Actions
Failure
ap-justin
had a problem deploying
to
production
November 16, 2024 07:16
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BG-1563
Towards BG-1530
Explanation of the solution
location.state
to search params e.g._s
, which is available to loadersInstructions on making this work
yarn
oryarn install
to install npm dependenciesyarn run test --watchAll
to verify all tests still passyarn run build
to verify the build passesyarn start
to start the webappUI changes for review
When major UI changes are introduced with a PR, please include links to URLS to compare or screenshots demonstrating the difference and notify on design changes