Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global rate limit: moderate requests sent #219

Open
idkfrancis opened this issue May 15, 2021 · 4 comments
Open

Global rate limit: moderate requests sent #219

idkfrancis opened this issue May 15, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@idkfrancis
Copy link

idkfrancis commented May 15, 2021

Hello, is it possible to add an option to limit the backup loading to 15 actions per second so as not to reach 10,000 requests every 10 minutes. For some large essential backups, the size of the backup can greatly exceed 10,000 requests and the backup robot can get blocked by Discord (https://discord.com/developers/docs/topics/rate-limits).
I imagine that we should add an option that allows to set the backup loading mode, such as "fast" for light backups (less than 10k actions to be done) which would revert to the current system and another "slow" model for heavy backups (+ 10k) to limit the loading of the backup to 15 actions per second.
For the moment I have the impression that the backup loading stops at around 10,000 requests for me and does not continue after several ten minutes. It's problematic to have a backup but not be able to load it correctly.
This feature would be very useful and I thank you in advance.

@Androz2091
Copy link
Owner

Hello,
Even if I don't need it personally, I understand that it can be necessary for large bots having to load heavy backups. Feel free to submit a pull request if you know how to code this, otherwise I'll do it when I have time 👍

@Androz2091 Androz2091 added the enhancement New feature or request label May 15, 2021
@idkfrancis
Copy link
Author

I would have liked to help you but I am a beginner I have no idea how to do this in an optimized way. I'd be happy to see your code and how you went about implementing it :)

shaynlink referenced this issue in shaynlink/discord-backup Jun 6, 2021
@Tdarnell
Copy link

Please merge this pull request! #233 I am unable to restore my backup without it

@Androz2091
Copy link
Owner

Please leave a review in the pr then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants