Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to native Typescript support #201

Open
1 task
AndreaPontrandolfo opened this issue Aug 11, 2024 · 4 comments · May be fixed by #269
Open
1 task

Transition to native Typescript support #201

AndreaPontrandolfo opened this issue Aug 11, 2024 · 4 comments · May be fixed by #269
Labels
accepted The issue is accepted and a PR can be proposed. refactor

Comments

@AndreaPontrandolfo
Copy link
Owner

AndreaPontrandolfo commented Aug 11, 2024 •
edited
Loading

ESLint now supports eslint.config.{ts,cts,mts} natively. We should adopt that instead of our custom implementation with eslint-ts-patch.

Requirements:
@AndreaPontrandolfo

This comment was marked as outdated.

Sign in to view
@AndreaPontrandolfo AndreaPontrandolfo added refactor accepted The issue is accepted and a PR can be proposed. labels Aug 17, 2024
@lishaduck
Copy link
Contributor

Fixed by #225?
I saw some parts in the diff about ts.

@AndreaPontrandolfo
Copy link
Owner Author

Oh no, we are still on antfu/eslint-ts-patch.
I'm waiting for the dust to settle on microsoft/vscode-eslint#1917 before migrating.

@AndreaPontrandolfo AndreaPontrandolfo added triaging Issue is still being evaluated. PRs not yet accepted. and removed accepted The issue is accepted and a PR can be proposed. labels Aug 31, 2024
@AndreaPontrandolfo
Copy link
Owner Author

Sooooo, i just realized that it's pointless to wait for microsoft/vscode-eslint#1917 anyway.
microsoft/vscode-eslint#1917 is a problem with the ESLint VSCode extension, not with the ESLint implementation of TS support, so it doesn't make sense to hold this for that.

@AndreaPontrandolfo AndreaPontrandolfo linked a pull request Oct 24, 2024 that will close this issue
docs: 📝 adds VSCode instructions for official ESlint > v9.9.0 (#268) #269
Draft
@AndreaPontrandolfo AndreaPontrandolfo added accepted The issue is accepted and a PR can be proposed. and removed triaging Issue is still being evaluated. PRs not yet accepted. labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted The issue is accepted and a PR can be proposed. refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: 📝 adds VSCode instructions for official ESlint > v9.9.0 (#268) sangrepura/sheriff
2 participants
@AndreaPontrandolfo @lishaduck