I've created and tested a null safe version. #23
Conversation
… it looks like its about to be published and once done this code will work. All unit tests are passing using a local copy of uri.
|
Whilst experimenting I added a funding.yml to this project. Only just noticed after raising the PR. I've now removed. |
|
And the null safe version of the uri package has just been plublished! |
…ed the dependency. I also had the incorrect sdk version as it was too specific.
… I've updated the version no. to 1.0.0 and changed imports to relative (unrelated.)
|
Can someone review this? @aholmgren |
|
Time to merge this! |
|
I need to find a new owner for this repo as I no longer have anything to do with dart any volunteers? |
|
@bsutton seems like a solid candidate and already has pubspec2 up on pubdev, but if he doesn't want to take up the mantle then I will, I am always online. |
|
@j4qfrost @Andersmholmgren @j4qfrost if you are happy to take up the mantel I will help where I can. |
|
Cool, I'll take over the project. Thanks for building it. I'll see if I can actually push out a nullsafety version tonight on pubdev. Unless you want to @Andersmholmgren |
|
Thanks.
…On Tue, 9 Mar 2021, 6:15 pm j4qfrost, ***@***.***> wrote:
Cool, I'll take over the project. Thanks for building it. I'll see if I
can actually push out a nullsafety version tonight on pubdev.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG32OFXK4M65RIEBFJO6RLTCXDKDANCNFSM4XXJKLVA>
.
|
|
It's all setup in my fork and published, I merged in the const constructors as well, sorry for the wait. |
|
@j4qfrost thanks for the work! |
It currently relies on an unpublished version of uri but it looks like its about to be published.
Obviously you don't want to merge until the uri version is published but since I needed a local copy I thought I should push the changes I've made.