Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/enable pdb qa #492

Merged
merged 2 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion env/qa/global.env
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ HERITABILITY_CONTAINER_VERSION=v0.04
HERITABILITY_TASK_QUEUE_NAME=caendr-qa-h2calc
HERITABILITY_EXAMPLE_FILE=data/heritability_example_{SPECIES}.tsv

PHENOTYPE_DB_ENABLED=False
PHENOTYPE_DB_ENABLED=True

FASTA_FILENAME_TEMPLATE={RELEASE}_{SPECIES}_{GENOME}.dev.genome
FASTA_EXTENSION_FILE=.fa
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@
// Update checked tags via event
document.addEventListener("{{table_id}}-update-tag", ({detail}) => {
const filterTag = $("#{{ table_id }}-tags-filter input[type=checkbox]").filter(function() {
console.log( $(this).attr('value'), detail.tagVal );
return $(this).attr('value') === detail.tagVal;
return $(this).attr('value').toLowerCase() === detail.tagVal.toLowerCase();
})
filterTag.prop('checked', true);
search();
Expand Down
2 changes: 1 addition & 1 deletion src/pkg/caendr/caendr/api/phenotype.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def get_trait_categories(query = None):
tags = filter(None, ( tr.get_tags() for tr in query ))

# Flatten the list of lists into a set, and sort the result
tags_list = { tg for tr_tag in tags for tg in tr_tag }
tags_list = { tg.title() for tr_tag in tags for tg in tr_tag }
return sorted(tags_list)


Expand Down
2 changes: 1 addition & 1 deletion src/pkg/caendr/caendr/models/sql/phenotype_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def get_tags(self):
If no tag set defined, returns None.
'''
if self.tags:
return { tg.strip() for tg in self.tags.split(',') }
return { tg.strip().lower() for tg in self.tags.split(',') }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor detail -- do we need a space after the comma, eg: , ?



def add(self, trait_obj):
Expand Down
Loading