What's the correct way to handle SIGWINCH

[amosbird]

When terminal gets resized, clickhouse-client (an replxx application) fails to render the display correctly unless it resets the current replxx-state. I wonder if there is any example I can refer to.

[AmokHuginnsson]

Does afb020a improve your experience?

[amosbird]

Does afb020a improve your experience?

Unfortunately nope. Nothing changed.

[AmokHuginnsson]

Do you call install_window_change_handler() in the client in the beginning?

[amosbird]

install_window_change_handler() That works!

There is one tiny issue left. After resizing, syntax highlighting gets lost. I have to input some actions such as moving cursors around to get it back.

edit

Just found another issue. When doing terminal shrink, replxx rerenders current line but somehow in a new line, with one line duplicated. Here is the screencast describing the issue http://oracle.wentropy.com/b5decbe52268770c

[AmokHuginnsson]

Current master should fix color issue.
But I haven't read your edit before I started working on syntax highlighting.

[amosbird]

Current master should fix color issue.

Awesome

But I haven't read your edit before I started working on syntax highlighting.

That just means you're super productive :)

[AmokHuginnsson]

I can reproduce duplicated line issue only in tmux, raw terminals do not show this problem.

[amosbird]

I can reproduce duplicated line issue only in tmux, raw terminals do not show this problem.

Hmm, what does that imply? I thought tmux should obey the terminal standard.

[AmokHuginnsson]

Hmm, what does that imply? I thought tmux should obey the terminal standard.

I do not know yet.

[AmokHuginnsson]

Ok, most terminals express this behavior (also GNU screen), the only unaffected terminals I found are xterm and rxvt derivatives (running without any terminal multiplexer).