-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: split_by_seasons FALSE API input not working #5
Labels
bug
Something isn't working
Comments
For future me, a reproducible example: https://app.americansocceranalysis.com/api/v1/mls/players/goals-added?minimum_minutes=6000&season_name=2018%2C2019&split_by_seasons=false. Also, this combination unexpectedly doesn't enforce the minutes filter: https://app.americansocceranalysis.com/api/v1/mls/players/goals-added?minimum_minutes=6000&season_name=2018%2C2019&split_by_seasons=false&split_by_teams=true&split_by_games=false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
The split_by_seasons 'false' option is not working in the API, as can be tested here.
When I try to select "false" from the dropdown menu I get a 500 error. Through the package's get_player_goals_added() function, you can pass "" or NULL or TRUE into this input to get what you expect, respectively, but not "false" or FALSE, or as it turns out, "fart" either.
Version
0.1.1
What version of Python or R are you using?
R 3.6.x
What operating system are you using?
Windows
Relevant log output
No response
The text was updated successfully, but these errors were encountered: