Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Use a snapshot for Ethereum adapter testing #403

Closed
elpiel opened this issue May 17, 2021 · 1 comment · Fixed by #447 or #486
Closed

[CI] Use a snapshot for Ethereum adapter testing #403

elpiel opened this issue May 17, 2021 · 1 comment · Fixed by #447 or #486
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elpiel
Copy link
Member

elpiel commented May 17, 2021 •
edited
Loading

Related to #380 & PR #385 and comment #385 (comment)
@elpiel elpiel added enhancement New feature or request good first issue Good for newcomers labels May 17, 2021
@elpiel elpiel linked a pull request Nov 11, 2021 that will close this issue
Update protocol-eth & make a snapshot for ganache-cli #447
Merged
@elpiel
Copy link
Member Author

elpiel commented Nov 11, 2021 •
edited
Loading

Since #447 we have a snapshot of the contracts needed for the test_harness, however, this snapshot can be used for testing the EthereumAdapter and currently it's not being used this way.

The snapshot should also be updated to include the Identity (see #452 ) contract too

@elpiel elpiel mentioned this issue Nov 11, 2021
Closed
1 task
@elpiel elpiel mentioned this issue Apr 14, 2022
Merged
@elpiel elpiel linked a pull request Apr 14, 2022 that will close this issue
Testing setup improvements & fix for ganache second instance snapshot #486
Merged
@elpiel elpiel closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@elpiel