Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all remote manifests ahead of time when adding packages #1214

Open
philpax opened this issue Dec 7, 2023 · 0 comments
Open

Fetch all remote manifests ahead of time when adding packages #1214

philpax opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement New feature or request topic:packages Package and package semantics. Dependencies, definitions, etc.

Comments

@philpax
Copy link
Contributor

philpax commented Dec 7, 2023

At present, manifests (and other files, like the build metadata) are fetched on-demand by the semantic system during addition. Unfortunately, as packages are added one-by-one, this means that the fetching of the manifests is inherently serial, even when they don't depend on each other.

This can be resolved by adding an initial gather phase, in which all of the manifests are fetched in parallel, and making the rest of the semantic system purely synchronous (as it will not need to fetch anything once the initial fetches are complete).

This doesn't have much of an impact right now, but could be a problem as wider and deeper package hierarchies are created with remote-only dependencies.

@philpax philpax added enhancement New feature or request topic:packages Package and package semantics. Dependencies, definitions, etc. labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic:packages Package and package semantics. Dependencies, definitions, etc.
Projects
None yet
Development

No branches or pull requests

1 participant