Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Rules engine runner service (it) tests #1652

Closed
mrednic-1A opened this issue Apr 15, 2024 · 0 comments · Fixed by #1655
Closed

[Feature]: Rules engine runner service (it) tests #1652

mrednic-1A opened this issue Apr 15, 2024 · 0 comments · Fixed by #1655
Labels
enhancement New feature or request

Comments

@mrednic-1A
Copy link
Contributor

Context

Rules engine integration tests were present in v9 of otter.
With the split of action handlers on specific modules (config, loc ...) the integration test of RulesEngineRunnerService should adapt.

Proposal

Get the integration test file from v9 and adapt it by mocking the action handlers, in order to avoid a circular dependency between rules engine module and action handler modules (configuration, loc ...)
@mrednic-1A mrednic-1A added the enhancement New feature or request label Apr 15, 2024
@mrednic-1A mrednic-1A reopened this Apr 15, 2024
@mrednic-1A mrednic-1A mentioned this issue Apr 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 15, 2024
@mrednic-1A
feat: rules engine runner service tests (#1655)
3f0d5a9 
## Proposed change

<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that is required for this change. -->

## Related issues

- 🐛 Fixes #(issue)
- 🚀 Feature #1652

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
@mrednic-1A mrednic-1A linked a pull request Apr 15, 2024 that will close this issue
feat: rules engine runner service tests #1655
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rules engine runner service tests AmadeusITGroup/otter
1 participant
@mrednic-1A