From 569f3d65cd3d14e1bd5d539fc0e81ca8715be885 Mon Sep 17 00:00:00 2001
From: matthieu-crouzet <matthieu.crouzet@amadeus.com>
Date: Thu, 31 Oct 2024 09:40:27 +0100
Subject: [PATCH] fix(accessibility): import the full module to have all
 accessibilities features

---
 .../src/app/rules-engine/rules-engine.component.ts        | 8 ++------
 .../src/app/rules-engine/rules-engine.template.html       | 8 ++++----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/apps/showcase/src/app/rules-engine/rules-engine.component.ts b/apps/showcase/src/app/rules-engine/rules-engine.component.ts
index b6b608c38f..b5491ae784 100644
--- a/apps/showcase/src/app/rules-engine/rules-engine.component.ts
+++ b/apps/showcase/src/app/rules-engine/rules-engine.component.ts
@@ -1,7 +1,7 @@
 import { AsyncPipe } from '@angular/common';
 import { AfterViewInit, ChangeDetectionStrategy, Component, inject, QueryList, ViewChildren, ViewEncapsulation } from '@angular/core';
 import { RouterModule } from '@angular/router';
-import { NgbNav, NgbNavContent, NgbNavItem, NgbNavLink, NgbNavOutlet } from '@ng-bootstrap/ng-bootstrap';
+import { NgbNavModule } from '@ng-bootstrap/ng-bootstrap';
 import { ApplicationDevtoolsModule } from '@o3r/application';
 import { ComponentsDevtoolsModule } from '@o3r/components';
 import { ConfigOverrideStoreModule, ConfigurationBaseServiceModule, ConfigurationDevtoolsModule } from '@o3r/configuration';
@@ -54,11 +54,7 @@ import { duringSummer } from '../../operators/index';
     CopyTextPresComponent,
     RouterModule,
     IN_PAGE_NAV_PRES_DIRECTIVES,
-    NgbNav,
-    NgbNavItem,
-    NgbNavLink,
-    NgbNavContent,
-    NgbNavOutlet,
+    NgbNavModule,
     AsyncPipe
   ],
   templateUrl: './rules-engine.template.html',
diff --git a/apps/showcase/src/app/rules-engine/rules-engine.template.html b/apps/showcase/src/app/rules-engine/rules-engine.template.html
index 44123b08f4..8f77711156 100644
--- a/apps/showcase/src/app/rules-engine/rules-engine.template.html
+++ b/apps/showcase/src/app/rules-engine/rules-engine.template.html
@@ -31,7 +31,7 @@ <h2 id="rules-engine-example">Example</h2>
       </p>
       <a href="https://github.com/AmadeusITGroup/otter/blob/main/apps/showcase/src/components/showcase/rules-engine" target="_blank" rel="noopener">Source code</a>
       <ul ngbNav #nav="ngbNav" class="nav nav-tabs mt-3">
-        <li ngbNavItem class="nav-item" role="presentation">
+        <li ngbNavItem class="nav-item">
           <a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'configuration'" (click)="activateRuleTab('configuration')">Configuration rule</a>
           <ng-template ngbNavContent>
             <p>
@@ -45,7 +45,7 @@ <h2 id="rules-engine-example">Example</h2>
             <o3r-copy-text-pres language="json" [text]="newYorkAvailableRule"></o3r-copy-text-pres>
           </ng-template>
         </li>
-        <li ngbNavItem class="nav-item" role="presentation">
+        <li ngbNavItem class="nav-item">
           <a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'localization'" (click)="activateRuleTab('localization')">Localization rule</a>
           <ng-template ngbNavContent>
             <p>
@@ -54,7 +54,7 @@ <h2 id="rules-engine-example">Example</h2>
             <o3r-copy-text-pres language="json" [text]="helloNewYorkRule"></o3r-copy-text-pres>
           </ng-template>
         </li>
-        <li ngbNavItem class="nav-item" role="presentation">
+        <li ngbNavItem class="nav-item">
           <a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'dynamic-content'" (click)="activateRuleTab('dynamic-content')">Dynamic content rule</a>
           <ng-template ngbNavContent>
             <p>
@@ -65,7 +65,7 @@ <h2 id="rules-engine-example">Example</h2>
             <o3r-copy-text-pres language="json" [text]="summerOtterRule"></o3r-copy-text-pres>
           </ng-template>
         </li>
-        <li ngbNavItem class="nav-item" role="presentation">
+        <li ngbNavItem class="nav-item">
           <a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'operator-fact'" (click)="activateRuleTab('operator-fact')">Operator fact</a>
           <ng-template ngbNavContent>
             <p>