-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create tree component #999
feat: Create tree component #999
Conversation
ab1a56b
to
8ff4407
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 92.11% 91.87% -0.24%
==========================================
Files 94 98 +4
Lines 2535 2670 +135
Branches 421 438 +17
==========================================
+ Hits 2335 2453 +118
- Misses 130 140 +10
- Partials 70 77 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
451b793
to
a1dda6b
Compare
a1dda6b
to
0fa9f4e
Compare
Hi the screenreader is not fully working when expanding / collapsing the node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the keyboard navigation with screenreader
0fa9f4e
to
71add32
Compare
208c027
to
16b8cac
Compare
80fd954
to
24d5a34
Compare
1802fac
to
47e95d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks @MarkoOleksiyenko for this new component !
svelte/bootstrap/src/components/tree/TreeDefaultStructure.svelte
Outdated
Show resolved
Hide resolved
svelte/bootstrap/src/components/tree/TreeDefaultStructure.svelte
Outdated
Show resolved
Hide resolved
dae3cbc
to
de2b3ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagged all fixed comments as resolved, thx @MarkoOleksiyenko !
ed5a197
to
c3c2b49
Compare
c3c2b49
to
bb403cf
Compare
Before submitting the PR, please make sure you do the following:
Tests and linting
npm run test
npm run lint
npm run e2e
Thank you for contributing to AgnosUI!