Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create tree component #999

Merged

Conversation

MarkoOleksiyenko
Copy link
Contributor

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Reference your PR to an issue that was discussed ahead of time
  • The PR should contain a clear description of the problem it solves
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the unit tests with npm run test
  • Run the linting with npm run lint
  • Run the e2e tests with npm run e2e

Thank you for contributing to AgnosUI!

@MarkoOleksiyenko MarkoOleksiyenko force-pushed the tree-component branch 3 times, most recently from ab1a56b to 8ff4407 Compare November 4, 2024 14:49
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 87.40741% with 17 lines in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (de19c38) to head (bb403cf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
core/src/components/tree/tree.ts 88.29% 4 Missing and 7 partials ⚠️
...ar/bootstrap/src/components/tree/tree.component.ts 72.22% 5 Missing ⚠️
core-bootstrap/src/components/tree/tree.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   92.11%   91.87%   -0.24%     
==========================================
  Files          94       98       +4     
  Lines        2535     2670     +135     
  Branches      421      438      +17     
==========================================
+ Hits         2335     2453     +118     
- Misses        130      140      +10     
- Partials       70       77       +7     
Flag Coverage Δ
e2e 83.25% <87.40%> (+0.22%) ⬆️
unit 84.48% <57.44%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ExFlo
Copy link
Contributor

ExFlo commented Nov 5, 2024

Hi the screenreader is not fully working when expanding / collapsing the node.

Copy link
Contributor

@ExFlo ExFlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the keyboard navigation with screenreader

angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
core/src/components/tree/tree.ts Outdated Show resolved Hide resolved
core/src/components/tree/tree.ts Outdated Show resolved Hide resolved
core-bootstrap/src/scss/_variables.scss Outdated Show resolved Hide resolved
core-bootstrap/src/scss/tree.scss Outdated Show resolved Hide resolved
core-bootstrap/src/scss/tree.scss Outdated Show resolved Hide resolved
core/src/components/tree/tree.ts Outdated Show resolved Hide resolved
react/bootstrap/src/components/tree/tree.tsx Outdated Show resolved Hide resolved
svelte/bootstrap/src/components/tree/Tree.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks @MarkoOleksiyenko for this new component !

angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
angular/bootstrap/src/components/tree/tree.component.ts Outdated Show resolved Hide resolved
svelte/demo/src/bootstrap/samples/tree/Basic.route.svelte Outdated Show resolved Hide resolved
svelte/demo/src/bootstrap/samples/tree/Basic.route.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

@quentinderoubaix quentinderoubaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagged all fixed comments as resolved, thx @MarkoOleksiyenko !

@quentinderoubaix quentinderoubaix merged commit 1e3e802 into AmadeusITGroup:main Nov 26, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Tree widget
4 participants