Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add invalid code list upload test #14170

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Nov 26, 2024

Description

  • remove unnecessary use of string interpolation in EditOptionList.tsx.
  • add test that checks if toast error is rendered when upload fails with unknown error.
  • remove raw render of unhandled backend error and render generic translated error message for all cases.
  • use more precise text keys for error messages.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 26, 2024
@standeren standeren force-pushed the clean-up-error-handling-edit-option-list branch from c810d47 to 152e922 Compare November 26, 2024 10:45
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.35%. Comparing base (ab1a970) to head (47e1794).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...tions/OptionTabs/EditOptionList/EditOptionList.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14170      +/-   ##
==========================================
+ Coverage   95.33%   95.35%   +0.01%     
==========================================
  Files        1783     1785       +2     
  Lines       23230    23230              
  Branches     2693     2690       -3     
==========================================
+ Hits        22147    22151       +4     
+ Misses        836      833       -3     
+ Partials      247      246       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the clean-up-error-handling-edit-option-list branch from 8088352 to 4e87eb0 Compare November 26, 2024 11:19
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-documentation Issues where updating documentation is not relevant labels Nov 26, 2024
@ErlingHauan ErlingHauan self-assigned this Nov 27, 2024
@standeren
Copy link
Contributor Author

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.35%. Comparing base (ab1a970) to head (4e87eb0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tions/OptionTabs/EditOptionList/EditOptionList.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

We need to refactor the ServicesContext.tsx before it is possible to test this, see issue.

@ErlingHauan ErlingHauan assigned standeren and unassigned ErlingHauan Nov 27, 2024
@standeren standeren assigned ErlingHauan and unassigned standeren Nov 27, 2024
@ErlingHauan ErlingHauan removed their assignment Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: 🧪 Test
Development

Successfully merging this pull request may close these issues.

3 participants