-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete all Summary 2.0 components that has a reference to deleted component #14126
base: main
Are you sure you want to change the base?
Conversation
…elete-all-summary-20-components-that-has-a-reference-to-deleted-element-component-page-or-layout-set
string layout = TestDataHelper.GetFileFromRepo(org, app, developer, $"App/ui/{layoutSetName}/layouts/{layoutName}.json"); | ||
JsonNode layoutWithDeletedComponent = JsonNode.Parse(layout); | ||
JsonArray layoutArray = layoutWithDeletedComponent["data"]["layout"] as JsonArray; | ||
layoutArray.RemoveAt(0); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning test
layoutArray
this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14126 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 1797 1797
Lines 23367 23367
Branches 2703 2703
=======================================
Hits 22284 22284
Misses 836 836
Partials 247 247 ☔ View full report in Codecov by Sentry. |
Description
Delete all Summary 2.0 components that has a reference to deleted component
Related Issue(s)
Verification