-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge "select codelist" and "edit codelist" views #13685
Comments
When this is picked up, could you do a check-in with ux? |
I have some design suggestions for this merge. See Figma link |
🔥 The delete icon removes the code list that has been chosen, while edit icon edits the main file in the library. My intuitive expectation was that you would only edit the code list within the component itself, meaning the file would be overwritten and saved as a separate version within the component, independent of the file in the library. After all, you don’t delete the entire code list when you press delete here.🤔 So, we discussed what users intend to do with the code list when they choose to edit a code list retrieved from the library within the component. Do they want to edit the main file or customize the code list for their own use? We assume it’s likely the latter when working within the component—unless they find a typo in the code list that they will fix . Therefore, it might be confusing to let users edit directly in the library from the component, as we currently allow. We discussed possible solutions to improve the user experience:
We should create an issue and discuss this challenge with the domain😊 Feel free to share some screenshots @Konrad-Simso |
Here is a video of the current solution i've come up with after discussing options with Anniken last week. 20241120-0715-57.1485237.mp4I'm in the process of changing the color of the delete/remove choice button, we already have a studio component for this, i'd forgotten it exists. And also making the entire left side a clickable button to open the edit modal. |
Jeg lager et issue på å teste bibliotek og fokusere på redigering av kodeliste i komponenten Et annet alt for løsning er også å legge til en infotekst :D |
The user should be able to edit a codelist regardless of whether it's a predefined codelist or a codelist that is defined directly on the component. When we have this functionality in place, we should merge these to views into one. However, we should leave some visual clues to let the user know whether they are working on a predefined codelist or a direct one.
Additional information
Based on meeting about how we handle saving across the Studio solution, we should strive to always use debounce, but if that involves technical issues, we should save on
onBlur
instead of ononChange
.A part of this issue will therefore include adapting the
StudioCodeListEditor
usage in ux-editor to take advantage of theonBlur
callback instead of theonChange
callback.Dependencies
The text was updated successfully, but these errors were encountered: