From f58eb6454fc84ea9cab64cd68557434d99d2a635 Mon Sep 17 00:00:00 2001 From: Ahmed-Ghanam Date: Wed, 9 Oct 2024 16:34:13 +0200 Subject: [PATCH] Follow the same naming pattern --- .../Person/PersonRepositoryTests.cs | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonRepositoryTests.cs b/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonRepositoryTests.cs index 999b121..c1d1684 100644 --- a/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonRepositoryTests.cs +++ b/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonRepositoryTests.cs @@ -46,7 +46,7 @@ public void Dispose() } [Fact] - public async Task GetUserContactInfoAsync_ReturnsContactInfo_WhenFound() + public async Task GetContactDetailsAsync_WhenFound_ReturnsContactInfo() { // Act var result = await _registerRepository.GetContactDetailsAsync(["17111933790"]); @@ -60,64 +60,64 @@ public async Task GetUserContactInfoAsync_ReturnsContactInfo_WhenFound() } [Fact] - public async Task GetUserContactInfoAsync_ReturnsCorrectResults_WhenValidAndInvalidNumbers() + public async Task GetContactDetailsAsync_WhenMultipleContactsFound_ReturnsMultipleContacts() { // Act - var result = _personContactAndReservationTestData.Where(e => e.FnumberAk == "28026698350"); - var expected = await _registerRepository.GetContactDetailsAsync(["28026698350", "nonexistent2"]); + var result = await _registerRepository.GetContactDetailsAsync(["24064316776", "11044314101"]); + var expected = _personContactAndReservationTestData + .Where(e => e.FnumberAk == "24064316776" || e.FnumberAk == "11044314101"); - // Assert invalid result - Assert.Single(result); - AssertRegisterProperties(expected.FirstOrDefault(), result.FirstOrDefault()); + // Assert + Assert.Equal(2, result.Count); + + foreach (var register in result) + { + var foundRegister = expected.FirstOrDefault(r => r.FnumberAk == register.FnumberAk); + Assert.NotNull(foundRegister); + AssertRegisterProperties(register, foundRegister); + } } [Fact] - public async Task GetUserContactInfoAsync_ReturnsEmpty_WhenNoneFound() + public async Task GetContactDetailsAsync_WhenNoNationalIdentityNumbersProvided_ReturnsEmpty() { // Act - var result = await _registerRepository.GetContactDetailsAsync(["nonexistent1", "nonexistent2"]); + var result = await _registerRepository.GetContactDetailsAsync([]); // Assert Assert.Empty(result); } [Fact] - public async Task GetUserContactInfoAsync_ReturnsEmpty_WhenNotFound() + public async Task GetContactDetailsAsync_WhenNoneFound_ReturnsEmpty() { // Act - var result = await _registerRepository.GetContactDetailsAsync(["nonexistent", "11044314120"]); + var result = await _registerRepository.GetContactDetailsAsync(["nonexistent1", "nonexistent2"]); // Assert Assert.Empty(result); } [Fact] - public async Task GetUserContactInfoAsync_ReturnsMultipleContacts_WhenFound() + public async Task GetContactDetailsAsync_WhenNotFound_ReturnsEmpty() { // Act - var result = await _registerRepository.GetContactDetailsAsync(["24064316776", "11044314101"]); - var expected = _personContactAndReservationTestData - .Where(e => e.FnumberAk == "24064316776" || e.FnumberAk == "11044314101"); + var result = await _registerRepository.GetContactDetailsAsync(["nonexistent", "11044314120"]); // Assert - Assert.Equal(2, result.Count); - - foreach (var register in result) - { - var foundRegister = expected.FirstOrDefault(r => r.FnumberAk == register.FnumberAk); - Assert.NotNull(foundRegister); - AssertRegisterProperties(register, foundRegister); - } + Assert.Empty(result); } [Fact] - public async Task GetUserContactInfoAsync_ReturnsEmpty_WhenNoNationalIdentityNumbersProvided() + public async Task GetContactDetailsAsync_WhenValidAndInvalidNumbers_ReturnsCorrectResults() { // Act - var result = await _registerRepository.GetContactDetailsAsync([]); + var result = _personContactAndReservationTestData.Where(e => e.FnumberAk == "28026698350"); + var expected = await _registerRepository.GetContactDetailsAsync(["28026698350", "nonexistent2"]); - // Assert - Assert.Empty(result); + // Assert invalid result + Assert.Single(result); + AssertRegisterProperties(expected.FirstOrDefault(), result.FirstOrDefault()); } private static void AssertRegisterProperties(Person expected, Person actual)