Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of resourceId before doing Profile look up and Authorisation request #542

Open
khanrn opened this issue Jun 7, 2024 · 0 comments
Labels
kind/feature-request New feature or request

Comments

@khanrn
Copy link
Contributor

khanrn commented Jun 7, 2024

Description

While working on #510 it is discovered that there is (probably) no mechanism for verifying the existence of resourceId input before doing Profile look up and Authorisation request. It would be better to have such verification mechanism.

Reference:

var allUserContactPoints = await _profileClient.GetUserRegisteredContactPoints(orgNos, resourceId);

Probable Solution

  1. First we need to verify from Storage that the app exists with the resource ID.
  2. Then we need to verify the resource ID with a call to resource registry. Altinn Access Management has implemented a ResourceRegistryClient, which can be a source of inspiration to implement a client here in a similar fashion.

Additional Information

Related Issue(s) & PR(s):

  1. Add regression and use case tests that include an app affiliation #510
  2. #510 Implementation of adding regression and use case tests that include an app affiliation #540
@khanrn khanrn added the kind/feature-request New feature or request label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant