Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Icon button #54

Open
3 tasks
Febakke opened this issue Jun 28, 2022 · 3 comments
Open
3 tasks

Component: Icon button #54

Febakke opened this issue Jun 28, 2022 · 3 comments
Labels
kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue.

Comments

@Febakke
Copy link
Member

Febakke commented Jun 28, 2022

Description

Skjermbilde 2022-06-28 kl 12 41 36

Create one icon button to replace different version of this component in our products.

Tasks

  • What functionality do we need to support
  • Create sketches
  • Create tokens

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response
@Febakke Febakke added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Jun 28, 2022
@Albertlarsen Albertlarsen mentioned this issue Aug 2, 2022
Closed
12 tasks
@haakemon
Copy link
Contributor

haakemon commented Aug 8, 2022

@Febakke We also have (at least in older designs) a button with only an icon, ref this task: #79

Is that something we also should support? If so, do you have specs for that as well? 🙂

@Albertlarsen
Copy link
Contributor

If we use NAV and MUI as inspiration then this feature is about implementing startIcon on the button and not adding text on IconButton-component. Just to be explicit about it.

@haakemon
Copy link
Contributor

The visual styles on our button and this icon button style is very different, so I am not sure they are the same thing. Or perhaps we can adjust the visual style. It seems we will need to support icons in regular buttons as well, ref #26.

Thoughts @mrosvik @Febakke ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haakemon @Albertlarsen @Febakke