Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on luafilesystem #11

Closed
Alloyed opened this issue Sep 23, 2016 · 3 comments
Closed

Remove dependency on luafilesystem #11

Alloyed opened this issue Sep 23, 2016 · 3 comments

Comments

@Alloyed
Copy link
Owner

Alloyed commented Sep 23, 2016

This is the only native binary needed to install loverocks, and windows users may/may not have a compiler installed
afaik it's only used to handle templates, which we can just as easily hardcode.

@pablomayobre
Copy link
Contributor

luafilesystem is also required by luarocks if I'm not mistaken so it should be there most of the times

@Alloyed
Copy link
Owner Author

Alloyed commented Jul 7, 2017

It's not, actually :o

If
https://www.archlinux.org/packages/community/any/luarocks/files/
is to be believed it actually only needs to run pure lua files, and then shell out to system commands to work. On windows it bundles those system commands as .exe files, probably from cygwin or something.

Good Idea (tm) related to #12 incoming: instead of making a bundle that includes love. We make it so loverocks can be hosted by your love install directly. Instead of installing through luarocks, you'd get a .love app and you'd do something like "love bundle.love loverocks deps; and love bundle.love love-release ." to actually use it

@pablomayobre
Copy link
Contributor

Couldn't you use the luarocks functions instead? love-release does that.

Also I wouldn't dare to bundle luarocks as a .love file, it sounds tricky hahaha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants