Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save/Load is messy, with unwanted parameters getting saved #280

Closed
alexpiet opened this issue Mar 5, 2024 · 2 comments
Closed

Save/Load is messy, with unwanted parameters getting saved #280

alexpiet opened this issue Mar 5, 2024 · 2 comments
Labels
data upload documentation Improvements or additions to documentation good first issue Good for newcomers python

Comments

@alexpiet
Copy link
Collaborator

alexpiet commented Mar 5, 2024 •
edited
Loading

  • Both of these functions should be cleaned up and streamlined
  • StartExcitation is getting saved, which we fixed by forcing to be unchecked at the end of Open(), but we should instead screen for parameters like this that we dont want to save. (NewSession, Clear both get saved)
  • Both are kinda slow too, see if I can speed it up
@alexpiet alexpiet mentioned this issue Mar 5, 2024
Closed
3 tasks
@alexpiet
Copy link
Collaborator Author

partial overlapping with #304

@alexpiet alexpiet mentioned this issue May 30, 2024
Closed
@alexpiet alexpiet added documentation Improvements or additions to documentation good first issue Good for newcomers python labels May 30, 2024
@alexpiet alexpiet mentioned this issue Oct 22, 2024
Open
@alexpiet
Copy link
Collaborator Author

Closing as redundant of #800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data upload documentation Improvements or additions to documentation good first issue Good for newcomers python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexpiet